Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If MT brotli compression/decompression stops unexpectedly or after canceling, for instance in error case by write, if it was cut or by partial extraction, they may leak:
-mmt1
)writelist_done
orwritelist_busy
lists and they, in contrast towritelist_free
list, will not be freed (so leaking withwl
but also large buffer blockswl->out.buf
);This fix removes possible memory leakage in such cases.
In addition this PR has a small code deduplication (in brotli-mt_decompress.c:366-371).